[atlas] Atlas Sagan library and UDP tarceroute results: bug or feature?

Hi Daniel,

Thanks a lot for your response!

On Mon, Nov 17, 2014 at 5:56 PM, Daniel Quinn <dquinn at ripe.net> wrote:
> On 31/10/14 15:15, Jen Linkova wrote:
> The proposal is to remove target_responded and introduce two new properties:
>
> A boolean named destination_ip_responded to reflect the current behaviour of
> target_responded

It's nice to have but IMHO it's optional as it's easy to compare
destination_ip with the last responded hop ip if last_hop_responded is
set to True.

> A boolean named something like last_hop_responded or just target_responded
> representing whether the last hop was a response at all.

IMHO it would be very useful.
BTW a feature request: would it be possible to have a way to
distinguish between 'target did not respond/maxhops exceeded' and
'traceroute stopped because ICMP error message (but not Port
Unreachable in case of UDP traceroute) received)?

>
> What do you (and the others on this list) think of this? Making the change
> to Sagan is trivial, but I’d rather only do something like this once.
>
> I’d also happily audit and accept pull requests on GitHub if anyone fancies
> writing a patch themselves.



-- 
SY, Jen Linkova aka Furry