[atlas] Atlas Sagan library and UDP tarceroute results: bug or feature?

On 31/10/14 15:15, Jen Linkova wrote:

    I’ve just found that using Sagan library for analyzing UDP traceroute
    measurement results may produce incorrect results: ‘target_responded’
    variable is not be set to ‘True’ if the source address of the
    traceroute reply is not the target address of the traceroute, but any
    other address that belongs to the node.

Hi there, and sorry about the late reply on this. I’m the primary author
on Sagan and I’ve been on vacation for the past couple weeks.

This email was the topic of some debate in the office and we’ve arrived
at a few suggestions that I’d like some community feedback on if anyone
has two cents to throw this way:

The proposal is to remove |target_responded| and introduce two new
properties:

  * A boolean named |destination_ip_responded| to reflect the current
    behaviour of |target_responded|
  * A boolean named something like |last_hop_responded| or just
    |target_responded| representing whether the last hop was a response
    at all.

What do you (and the others on this list) think of this? Making the
change to Sagan is trivial, but I’d rather only do something like this once.

I’d also happily audit and accept pull requests
<https://github.com/RIPE-NCC/ripe.atlas.sagan> on GitHub if anyone
fancies writing a patch themselves.

​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </ripe/mail/archives/ripe-atlas/attachments/20141117/72dd2535/attachment.html>